Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Fix array transformation panic #880

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix array transformation panic #880

merged 1 commit into from
Oct 11, 2024

Conversation

@nablaone
Copy link
Member

@nablaone nablaone commented Oct 11, 2024 •
edited
Loading

It fixes this panel:

Screenshot 2024-10-11 at 16 15 05 
2024-10-11 16:32:13 Oct 11 14:32:13.599 ERR quesma/quesma/recovery/recovery_strategies.go:32 > Panic recovered: interface conversion: interface {} is model.SelectCommand, not *model.SelectCommand
2024-10-11 16:32:13 goroutine 482 [running]:
2024-10-11 16:32:13 runtime/debug.Stack()
2024-10-11 16:32:13     /usr/local/go/src/runtime/debug/stack.go:26 +0x64
2024-10-11 16:32:13 quesma/quesma/recovery.commonRecovery({0x6857e0, 0x40005f0990}, 0x4000875da8?)
2024-10-11 16:32:13     /quesma/quesma/recovery/recovery_strategies.go:32 +0x154
2024-10-11 16:32:13 quesma/quesma/recovery.LogAndHandlePanic({0x8e22b0, 0x40005f8690}, 0x4000877940)
2024-10-11 16:32:13     /quesma/quesma/recovery/recovery_strategies.go:51 +0x68
2024-10-11 16:32:13 panic({0x6857e0?, 0x40005f0990?})
2024-10-11 16:32:13     /usr/local/go/src/runtime/panic.go:785 +0x124
2024-10-11 16:32:13 quesma/model.(*BaseExprVisitor).VisitCTE(0x40008760e8?, {{0x75ba75?, 0x40005fb950?}, 0x4000b7e2c0?})
2024-10-11 16:32:13     /quesma/model/base_visitor.go:209 +0x110
2024-10-11 16:32:13 quesma/model.CTE.Accept(...)
2024-10-11 16:32:13     /quesma/model/expr.go:272
2024-10-11 16:32:13 quesma/quesma.checkIfGroupingByArrayColumn.func2(0x40005fb950, {0x0, {0x4000b6e880, 0x6, 0x8}, {0x8dc260, 0x40003213d0}, {0x8dc280, 0x40004c86f0}, {0x0, ...}, ...})
2024-10-11 16:32:13     /quesma/quesma/schema_array_transformer.go:144 +0x144
2024-10-11 16:32:13 quesma/model.(*BaseExprVisitor).VisitSelectCommand(0x0?, {0x0, {0x4000b6e880, 0x6, 0x8}, {0x8dc260, 0x40003213d0}, {0x8dc280, 0x40004c86f0}, {0x0, ...}, ...})
2024-10-11 16:32:13     /quesma/model/base_visitor.go:140 +0x8c
2024-10-11 16:32:13 quesma/model.SelectCommand.Accept(...)
2024-10-11 16:32:13     /quesma/model/select.go:40
2024-10-11 16:32:13 quesma/quesma.checkIfGroupingByArrayColumn({0x0, {0x4000b6e880, 0x6, 0x8}, {0x8dc260, 0x40003213d0}, {0x8dc280, 0x40004c86f0}, {0x0, 0x0, ...}, ...}, ...)
2024-10-11 16:32:13     /quesma/quesma/schema_array_transformer.go:167 +0x1d0
2024-10-11 16:32:13 quesma/quesma.(*SchemaCheckPass).applyArrayTransformations(0x4000876608?, {0x40009b4ea0, 0x40009b4f00, 0x1, {0x74c4c7, 0x7}}, 0x4000574480)
2024-10-11 16:32:13     /quesma/quesma/schema_transformer.go:298 +0x14c
2024-10-11 16:32:13 quesma/quesma.(*SchemaCheckPass).Transform(0x400006e108, {0x40003e8858, 0x3, 0x3})
2024-10-11 16:32:13     /quesma/quesma/schema_transformer.go:767 +0x4f8
...

@nablaone nablaone marked this pull request as ready for review October 11, 2024 14:18
@nablaone nablaone requested a review from a team as a code owner October 11, 2024 14:18
@pdelewski
Copy link
Contributor

pdelewski commented Oct 11, 2024

Could you add more information about panic?

@nablaone nablaone added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 7ba3d84 Oct 11, 2024
4 checks passed
@nablaone nablaone deleted the pr-array-select-fix branch October 11, 2024 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakozaur jakozaur Awaiting requested review from jakozaur jakozaur is a code owner automatically assigned from QuesmaOrg/engineering

@mieciu mieciu Awaiting requested review from mieciu mieciu is a code owner automatically assigned from QuesmaOrg/engineering

@trzysiek trzysiek Awaiting requested review from trzysiek trzysiek is a code owner automatically assigned from QuesmaOrg/engineering

@avelanarius avelanarius Awaiting requested review from avelanarius avelanarius is a code owner automatically assigned from QuesmaOrg/engineering

1 more reviewer

@pdelewski pdelewski pdelewski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nablaone @pdelewski